Handle out-of-bounds coordinates during evaluation#259
Merged
jacobmerson merged 4 commits intoSCOREC:developfrom Feb 27, 2026
Merged
Handle out-of-bounds coordinates during evaluation#259jacobmerson merged 4 commits intoSCOREC:developfrom
jacobmerson merged 4 commits intoSCOREC:developfrom
Conversation
Collaborator
|
@hgangwar please review this when you get a chance. Changes here are what we discussed about handling points outside the domain. |
jacobmerson
requested changes
Feb 15, 2026
Sichao25
force-pushed
the
yus/out_of_bound_mode
branch
from
932e6f0 to
ef55cbc
Compare
|
@jacobmerson , the test case validates exactly the functionality we need. As I understand it, any out of bounds vertex's element index is marked as something |
jacobmerson
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle out-of-bounds cases by throwing an exception or filling a given value. NEAREST_BOUNDARY mode (map to nearest elements) is not yet implemented.